debont80/AeroFetch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Fix L48: strip ERROR: prefix from errorlog seed data to match production

Browse Source 
cleanError() strips leading 'ERROR:' from yt-dlp stderr before sending
errors to the UI and error log. The browser-preview seed entry in
store/errorlog.ts had the raw 'ERROR: [youtube]...' prefix, making the
preview inconsistent with what production shows. Removed the prefix from
the seed string so the preview and production rendering match.

typecheck + 242 tests green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Devon Bontrager
2026-06-30 14:44:18 -04:00
parent 036ef74362
commit fa4b41e0a5
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CODE-AUDIT.md
+1 -1
View File
@@ -473,7 +473,7 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
"Reinstall AeroFetch, or drop…" vs "Download it into resources/bin/…" vs "Drop it into resources/bin/." "Reinstall AeroFetch, or drop…" vs "Download it into resources/bin/…" vs "Drop it into resources/bin/."
- [x] **L47 — `probeMeta` 30s timeout returns null silently** — no surfaced message, unlike every - [x] **L47 — `probeMeta` 30s timeout returns null silently** — no surfaced message, unlike every
other yt-dlp timeout ("Timed out …"). other yt-dlp timeout ("Timed out …").
- [ ] **L48 — `cleanError` strips a leading `error:`** for live failures, while raw `ERROR:` text - [x] **L48 — `cleanError` strips a leading `error:`** for live failures, while raw `ERROR:` text
shows elsewhere (errorlog seed / terminal) — inconsistent error normalization. shows elsewhere (errorlog seed / terminal) — inconsistent error normalization.
- [x] **L49 — Newlines in user-facing error strings.** download.ts missing-binary messages embed - [x] **L49 — Newlines in user-facing error strings.** download.ts missing-binary messages embed
`\n`, which renders awkwardly in inline/Caption error spans. `\n`, which renders awkwardly in inline/Caption error spans.
src/renderer/src/store/errorlog.ts
+1 -1
View File
@@ -13,7 +13,7 @@ const seed: ErrorLogEntry[] = PREVIEW
title: 'Private video', title: 'Private video',
url: 'https://youtube.com/watch?v=err0r', url: 'https://youtube.com/watch?v=err0r',
kind: 'video', kind: 'video',
error: 'ERROR: [youtube] err0r: Private video. Sign in if you have access.', error: '[youtube] err0r: Private video. Sign in if you have access.',
occurredAt: Date.now() - 1000 * 60 * 12 occurredAt: Date.now() - 1000 * 60 * 12
} }
] ]