From fa4b41e0a5024c6189b2cd7d7ad2837af91814ee Mon Sep 17 00:00:00 2001 From: debont80 Date: Tue, 30 Jun 2026 14:44:18 -0400 Subject: [PATCH] Fix L48: strip ERROR: prefix from errorlog seed data to match production cleanError() strips leading 'ERROR:' from yt-dlp stderr before sending errors to the UI and error log. The browser-preview seed entry in store/errorlog.ts had the raw 'ERROR: [youtube]...' prefix, making the preview inconsistent with what production shows. Removed the prefix from the seed string so the preview and production rendering match. typecheck + 242 tests green. Co-Authored-By: Claude Opus 4.8 --- CODE-AUDIT.md | 2 +- src/renderer/src/store/errorlog.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CODE-AUDIT.md b/CODE-AUDIT.md index deb9368..e8ee0ae 100644 --- a/CODE-AUDIT.md +++ b/CODE-AUDIT.md @@ -473,7 +473,7 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n "Reinstall AeroFetch, or drop…" vs "Download it into resources/bin/…" vs "Drop it into resources/bin/." - [x] **L47 — `probeMeta` 30s timeout returns null silently** — no surfaced message, unlike every other yt-dlp timeout ("Timed out …"). -- [ ] **L48 — `cleanError` strips a leading `error:`** for live failures, while raw `ERROR:` text +- [x] **L48 — `cleanError` strips a leading `error:`** for live failures, while raw `ERROR:` text shows elsewhere (errorlog seed / terminal) — inconsistent error normalization. - [x] **L49 — Newlines in user-facing error strings.** download.ts missing-binary messages embed `\n`, which renders awkwardly in inline/Caption error spans. diff --git a/src/renderer/src/store/errorlog.ts b/src/renderer/src/store/errorlog.ts index 8c490a9..dda7b77 100644 --- a/src/renderer/src/store/errorlog.ts +++ b/src/renderer/src/store/errorlog.ts @@ -13,7 +13,7 @@ const seed: ErrorLogEntry[] = PREVIEW title: 'Private video', url: 'https://youtube.com/watch?v=err0r', kind: 'video', - error: 'ERROR: [youtube] err0r: Private video. Sign in if you have access.', + error: '[youtube] err0r: Private video. Sign in if you have access.', occurredAt: Date.now() - 1000 * 60 * 12 } ]