debont80/AeroFetch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Self-review: fix stale comment quoting renamed empty-state string

Browse Source 
Review of this session's audit batch (L106/L107/L122, L119/L151/L153, M3, M17,
M18, M23/M27, R8, L62). One issue found and fixed:

- SettingsView copyErrorReport comment quoted the old "No errors logged."
  empty-state string, which L119 renamed to "No errors yet." Reworded the
  comment to not quote a specific string.

Everything else verified sound: M3 recordCompletion is a faithful extraction
(+ a correct canceled-item bugfix); M17 status precedence; M18 migration; M23
per-source budget cap; M27 enqueueKind state is safe (only the expanded source
renders its detail); R8 pretty flag; L62 drop of the synthetic ext has no
consumers. No BOM churn. The incidental em-dash->-- conversions in
jsonStore/sources comments leave each file internally consistent and aligned
with the project's ASCII convention, so they stand.

typecheck + 242 tests + eslint green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Devon Bontrager
2026-06-30 16:02:42 -04:00
parent 0f572488fc
commit 6c19899f75
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/SettingsView.tsx
+1 -1
View File
@@ -378,7 +378,7 @@ export function SettingsView(): React.JSX.Element {
function copyErrorReport(): void { function copyErrorReport(): void {
// The button is disabled when there are no entries, so `report` is always // The button is disabled when there are no entries, so `report` is always
// non-empty here -- no need for an unreachable "No errors logged." fallback (L159). // non-empty here -- no need for an unreachable empty-report fallback (L159).
const report = errorEntries const report = errorEntries
.map((e) => .map((e) =>
[new Date(e.occurredAt).toLocaleString(), e.title ?? e.url, e.url, e.error].join('\n') [new Date(e.occurredAt).toLocaleString(), e.title ?? e.url, e.url, e.error].join('\n')