From 6c19899f75d7399618c3a306cb653b2dda83f55f Mon Sep 17 00:00:00 2001 From: debont80 Date: Tue, 30 Jun 2026 16:02:42 -0400 Subject: [PATCH] Self-review: fix stale comment quoting renamed empty-state string Review of this session's audit batch (L106/L107/L122, L119/L151/L153, M3, M17, M18, M23/M27, R8, L62). One issue found and fixed: - SettingsView copyErrorReport comment quoted the old "No errors logged." empty-state string, which L119 renamed to "No errors yet." Reworded the comment to not quote a specific string. Everything else verified sound: M3 recordCompletion is a faithful extraction (+ a correct canceled-item bugfix); M17 status precedence; M18 migration; M23 per-source budget cap; M27 enqueueKind state is safe (only the expanded source renders its detail); R8 pretty flag; L62 drop of the synthetic ext has no consumers. No BOM churn. The incidental em-dash->-- conversions in jsonStore/sources comments leave each file internally consistent and aligned with the project's ASCII convention, so they stand. typecheck + 242 tests + eslint green. Co-Authored-By: Claude Opus 4.8 --- src/renderer/src/components/SettingsView.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/src/components/SettingsView.tsx b/src/renderer/src/components/SettingsView.tsx index b361226..3fa1320 100644 --- a/src/renderer/src/components/SettingsView.tsx +++ b/src/renderer/src/components/SettingsView.tsx @@ -378,7 +378,7 @@ export function SettingsView(): React.JSX.Element { function copyErrorReport(): void { // The button is disabled when there are no entries, so `report` is always - // non-empty here -- no need for an unreachable "No errors logged." fallback (L159). + // non-empty here -- no need for an unreachable empty-report fallback (L159). const report = errorEntries .map((e) => [new Date(e.occurredAt).toLocaleString(), e.title ?? e.url, e.url, e.error].join('\n')