debont80/AeroFetch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

docs(exec): correct execFileAsync comment — schedule.ts is not migrated

Browse Source 
schedule.ts keeps its own schtasks wrapper because it needs the numeric exit
code (getScheduledSync checks r.code === 0), which execFileAsync deliberately
doesn't surface. The 5 migrated sites are probe/ytdlp(x2)/ffmpeg/indexer/
download.probeMeta. Comment-only.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Devon Bontrager
2026-07-01 10:25:36 -04:00
parent abd9f688b9
commit 63687aaec3
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/lib/exec.ts
+4 -3
View File
@@ -18,9 +18,10 @@ export interface ExecResult {
/** /**
* `execFile` as a promise that never rejects (audit SIMP2/CC4/CC5). Replaces the * `execFile` as a promise that never rejects (audit SIMP2/CC4/CC5). Replaces the
* six hand-rolled `new Promise((resolve) => execFile(…, cb))` wrappers across * six hand-rolled `new Promise((resolve) => execFile(…, cb))` wrappers across
* probe / ytdlp (×2) / ffmpeg / indexer / download.probeMeta / schedule — each * probe / ytdlp (×2) / ffmpeg / indexer / download.probeMeta — each caller now maps
* caller now maps this normalized result to its own shape instead of repeating the * this normalized result to its own shape instead of repeating the `err.killed`
* `err.killed` timeout check and the resolve/reject plumbing. * timeout check and the resolve/reject plumbing. (schedule.ts keeps its own wrapper:
* it needs the numeric exit code, which this helper deliberately doesn't surface.)
* *
* `windowsHide` defaults on (every caller wants the console window suppressed); * `windowsHide` defaults on (every caller wants the console window suppressed);
* pass `timeout` / `maxBuffer` per call exactly as before. * pass `timeout` / `maxBuffer` per call exactly as before.