From 63687aaec35a3f30f7fcfd070414b4906a6b97e9 Mon Sep 17 00:00:00 2001 From: debont80 Date: Wed, 1 Jul 2026 10:25:36 -0400 Subject: [PATCH] =?UTF-8?q?docs(exec):=20correct=20execFileAsync=20comment?= =?UTF-8?q?=20=E2=80=94=20schedule.ts=20is=20not=20migrated?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit schedule.ts keeps its own schtasks wrapper because it needs the numeric exit code (getScheduledSync checks r.code === 0), which execFileAsync deliberately doesn't surface. The 5 migrated sites are probe/ytdlp(x2)/ffmpeg/indexer/ download.probeMeta. Comment-only. Co-Authored-By: Claude Opus 4.8 --- src/main/lib/exec.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/lib/exec.ts b/src/main/lib/exec.ts index b11d53c..0f05d0b 100644 --- a/src/main/lib/exec.ts +++ b/src/main/lib/exec.ts @@ -18,9 +18,10 @@ export interface ExecResult { /** * `execFile` as a promise that never rejects (audit SIMP2/CC4/CC5). Replaces the * six hand-rolled `new Promise((resolve) => execFile(…, cb))` wrappers across - * probe / ytdlp (×2) / ffmpeg / indexer / download.probeMeta / schedule — each - * caller now maps this normalized result to its own shape instead of repeating the - * `err.killed` timeout check and the resolve/reject plumbing. + * probe / ytdlp (×2) / ffmpeg / indexer / download.probeMeta — each caller now maps + * this normalized result to its own shape instead of repeating the `err.killed` + * timeout check and the resolve/reject plumbing. (schedule.ts keeps its own wrapper: + * it needs the numeric exit code, which this helper deliberately doesn't surface.) * * `windowsHide` defaults on (every caller wants the console window suppressed); * pass `timeout` / `maxBuffer` per call exactly as before.