1376c2dee8
Audit-pass over CODE-AUDIT.md (~48 items closed this pass; all verified — typecheck + 234 tests + eslint + prettier green). Correctness / bugs: - B3: match the release checksum to the asset's filename line (no wrong-hash verify) - B4: newline-safe metadata probe (one --print with a unit-separator delimiter) - B5 / L88: guard the meta event against canceled items; progress no longer promotes a queued item outside pump() - B7: cookie-login promise always resolves (handles destroy-without-close) - L146: trim parser rejects >2 colon-group times; M36: Library selection counts only actionable rows - L11 / L50 / L156 / L57 / L159 / L15 / L3: live queue count, empty-cookie message, schedule picker min, dead-code/comment cleanup Type safety: - Enable noUncheckedIndexedAccess + noFallthroughCasesInSwitch (15 real edge cases fixed) Resilience / Windows / metadata: - R5: settings write failure handled (no unhandled IPC rejection; reconciles to truth) - W1 / W5 / W6: min window size, seeded folder picker, parented sign-in window; L147 dead macOS branches removed - CL1: shared stdout markers; package/builder metadata (license, homepage, repository, copyright, tsbuildinfo glob) Copy / docs / tests: - M37 / SR9 dev-jargon cleanup in hints; M8 / M25 / M26 / L66 / L80 / L81 reconciled - New unit tests for L35 (isValidMediaItem) and L36 (compareVersions) This commit also checkpoints the previously-uncommitted feat/tray-background-clipboard work it builds on: background running + auto-download, library clipboard detection, tray, binary management & library scale, credential encryption at rest, the shared jsonStore and ui/ primitives, and the eslint/prettier tooling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
99 lines
3.9 KiB
TypeScript
99 lines
3.9 KiB
TypeScript
import { app, nativeImage, type NativeImage } from 'electron'
|
|
import { join } from 'path'
|
|
import { is } from '@electron-toolkit/utils'
|
|
|
|
/**
|
|
* Resolves the directory holding the bundled binaries (yt-dlp.exe, ffmpeg.exe).
|
|
*
|
|
* In dev they live in the repo at resources/bin/.
|
|
* In a packaged build, electron-builder's extraResources copies them to
|
|
* <resources>/bin (see electron-builder.yml), reachable via process.resourcesPath.
|
|
*/
|
|
export function getBinDir(): string {
|
|
return is.dev ? join(app.getAppPath(), 'resources', 'bin') : join(process.resourcesPath, 'bin')
|
|
}
|
|
|
|
/**
|
|
* The app icon (.ico), for the system tray. In dev it's the repo's build/icon.ico;
|
|
* in a packaged build, electron-builder's extraResources copies it to
|
|
* <resources>/icon.ico (see electron-builder.yml).
|
|
*/
|
|
export function getAppIconPath(): string {
|
|
return is.dev
|
|
? join(app.getAppPath(), 'build', 'icon.ico')
|
|
: join(process.resourcesPath, 'icon.ico')
|
|
}
|
|
|
|
let appIconImage: NativeImage | null = null
|
|
/**
|
|
* The app icon as a cached NativeImage, for OS notifications (W13/L127). Loaded
|
|
* once from getAppIconPath(); a missing icon yields an empty image, which
|
|
* Notification treats as "no icon" (the OS default) rather than erroring. This
|
|
* gives completion/background toasts the real brand glyph — notably on the
|
|
* portable build, which has no installed AUMID shortcut icon for Windows to use.
|
|
*/
|
|
export function getAppIconImage(): NativeImage {
|
|
// Cache only a valid image so a transient read miss isn't latched forever; a
|
|
// genuinely-missing icon just re-reads (cheap — notifications are infrequent).
|
|
if (!appIconImage || appIconImage.isEmpty()) {
|
|
appIconImage = nativeImage.createFromPath(getAppIconPath())
|
|
}
|
|
return appIconImage
|
|
}
|
|
|
|
/**
|
|
* AeroFetch keeps its OWN writable copy of yt-dlp.exe under userData, separate
|
|
* from the read-only bundled seed in resources/bin. The managed copy is what
|
|
* actually gets spawned and self-updated (`--update-to`), so an app reinstall or
|
|
* portable re-extraction — which only ever replace the bundled seed — can never
|
|
* roll a freshly-updated yt-dlp back to a stale version. See ensureManagedYtdlp
|
|
* in ytdlp.ts, which seeds this from getBundledYtdlpPath() on first run.
|
|
*
|
|
* ffmpeg/ffprobe/aria2c stay in getBinDir(): they're not self-updating and
|
|
* yt-dlp finds them via `--ffmpeg-location <binDir>`.
|
|
*/
|
|
function getManagedBinDir(): string {
|
|
return join(app.getPath('userData'), 'bin')
|
|
}
|
|
|
|
/** The bundled, read-only yt-dlp.exe seeded into the managed copy when missing. */
|
|
export function getBundledYtdlpPath(): string {
|
|
return join(getBinDir(), 'yt-dlp.exe')
|
|
}
|
|
|
|
/** The managed (spawned + auto-updated) yt-dlp.exe under userData. */
|
|
export function getYtdlpPath(): string {
|
|
return join(getManagedBinDir(), 'yt-dlp.exe')
|
|
}
|
|
|
|
export function getFfmpegPath(): string {
|
|
return join(getBinDir(), 'ffmpeg.exe')
|
|
}
|
|
|
|
/**
|
|
* yt-dlp finds ffprobe via --ffmpeg-location (the bin dir), so the app never
|
|
* spawns it directly — but it must be present, or duration-aware post-processing
|
|
* (SponsorBlock-remove, --force-keyframes-at-cuts, --split-chapters) fails. This
|
|
* accessor exists so startDownload can assert its presence up front.
|
|
*/
|
|
export function getFfprobePath(): string {
|
|
return join(getBinDir(), 'ffprobe.exe')
|
|
}
|
|
|
|
/** Optional bundled external downloader; absent unless dropped into resources/bin. */
|
|
export function getAria2cPath(): string {
|
|
return join(getBinDir(), 'aria2c.exe')
|
|
}
|
|
|
|
/**
|
|
* Absolute path to a Windows system executable (e.g. taskkill.exe, schtasks.exe).
|
|
*
|
|
* SECURITY (audit F3): system tools are resolved by full path under System32
|
|
* rather than by bare name, so a same-named binary planted in the current
|
|
* working directory or earlier on PATH can't be invoked in their place — a real
|
|
* risk for the portable build, which runs from user-writable locations.
|
|
*/
|
|
export function getSystem32Path(exe: string): string {
|
|
return join(process.env.SystemRoot || 'C:\\Windows', 'System32', exe)
|
|
}
|