debont80
b08d76a986
Security: - S1 (backup.ts): require explicit confirmation before enabling custom-command templates from a backup file; import templates in a disabled state if declined - S2 (cookies.ts): deny non-http/https popups in cookie login window, matching the main window's setWindowOpenHandler defence - S3 (download.ts): main-process concurrency cap — startDownload now rejects spawns when active.size >= maxConcurrent (defence-in-depth; renderer already enforces this but should not be the only gate) - S4 (settings.ts, validation.ts): reject filenameTemplate values containing path traversal (.. segments or absolute paths); validate outputDir is absolute - S5 (history.ts, errorlog.ts, templates.ts, validation.ts): per-field validation on JSON reads — invalid entries dropped rather than blindly trusted Performance: - P1 (settings.ts): getSettings() now only writes to disk when sanitization actually changed a value; removes synchronous file I/O on every hot-path read - P2 (ipc.ts, download.ts, downloads.ts): renderer forwards its pre-probed metadata (title/channel/duration) via StartDownloadOptions.meta; main uses it directly instead of spawning a redundant second yt-dlp probe Maintainability: - M1 (log.ts, download.ts, probe.ts): extract duplicated cleanError() to src/main/log.ts; both callers import from the shared module - M2 (buildArgs.ts): document parseExtraArgs escape-sequence limitations - M3 (electron-builder.yml): clarify icon TODO as a pre-release action - P3 (downloads.ts): document that lowering maxConcurrent mid-flight does not pause active downloads (intended behaviour, now written down) Tests: - Add test/validation.test.ts covering isSafeFilenameTemplate, isSafeOutputDir, isValidHistoryEntry, isValidErrorLogEntry, isTemplateLike (76 tests pass) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
60 lines
1.9 KiB
TypeScript
60 lines
1.9 KiB
TypeScript
import { app } from 'electron'
|
|
import { join } from 'path'
|
|
import { readFileSync, writeFileSync, existsSync } from 'fs'
|
|
import type { HistoryEntry } from '@shared/ipc'
|
|
import { isValidHistoryEntry } from './validation'
|
|
|
|
// Plain JSON in userData (portable build redirects userData next to the exe).
|
|
// Kept simple per the build plan; can migrate to better-sqlite3 later.
|
|
const MAX_ENTRIES = 500
|
|
|
|
function historyFile(): string {
|
|
return join(app.getPath('userData'), 'history.json')
|
|
}
|
|
|
|
// Per-entry validation (isValidHistoryEntry, in validation.ts) so a hand-edited
|
|
// or corrupted history.json can't feed the UI (or openPath) entries with the
|
|
// wrong shape — invalid rows are dropped rather than trusted. (audit S5)
|
|
export function listHistory(): HistoryEntry[] {
|
|
try {
|
|
if (!existsSync(historyFile())) return []
|
|
const data = JSON.parse(readFileSync(historyFile(), 'utf8'))
|
|
return Array.isArray(data) ? data.filter(isValidHistoryEntry) : []
|
|
} catch {
|
|
return []
|
|
}
|
|
}
|
|
|
|
function save(entries: HistoryEntry[]): void {
|
|
try {
|
|
writeFileSync(historyFile(), JSON.stringify(entries.slice(0, MAX_ENTRIES), null, 2))
|
|
} catch {
|
|
/* best-effort; a read-only data dir just means no persisted history */
|
|
}
|
|
}
|
|
|
|
export function addHistory(entry: HistoryEntry): HistoryEntry[] {
|
|
// De-dupe by id (a retry of the same item replaces its prior entry).
|
|
const entries = [entry, ...listHistory().filter((e) => e.id !== entry.id)]
|
|
save(entries)
|
|
return entries
|
|
}
|
|
|
|
export function removeHistory(id: string): HistoryEntry[] {
|
|
const entries = listHistory().filter((e) => e.id !== id)
|
|
save(entries)
|
|
return entries
|
|
}
|
|
|
|
export function removeManyHistory(ids: string[]): HistoryEntry[] {
|
|
const remove = new Set(ids)
|
|
const entries = listHistory().filter((e) => !remove.has(e.id))
|
|
save(entries)
|
|
return entries
|
|
}
|
|
|
|
export function clearHistory(): HistoryEntry[] {
|
|
save([])
|
|
return []
|
|
}
|