Files
AeroFetch/src/main/schedule.ts
T
debont80 1376c2dee8 Harden audit findings: correctness, type-safety, Windows conventions & polish
Audit-pass over CODE-AUDIT.md (~48 items closed this pass; all verified —
typecheck + 234 tests + eslint + prettier green).

Correctness / bugs:
- B3: match the release checksum to the asset's filename line (no wrong-hash verify)
- B4: newline-safe metadata probe (one --print with a unit-separator delimiter)
- B5 / L88: guard the meta event against canceled items; progress no longer promotes
  a queued item outside pump()
- B7: cookie-login promise always resolves (handles destroy-without-close)
- L146: trim parser rejects >2 colon-group times; M36: Library selection counts only
  actionable rows
- L11 / L50 / L156 / L57 / L159 / L15 / L3: live queue count, empty-cookie message,
  schedule picker min, dead-code/comment cleanup

Type safety:
- Enable noUncheckedIndexedAccess + noFallthroughCasesInSwitch (15 real edge cases fixed)

Resilience / Windows / metadata:
- R5: settings write failure handled (no unhandled IPC rejection; reconciles to truth)
- W1 / W5 / W6: min window size, seeded folder picker, parented sign-in window;
  L147 dead macOS branches removed
- CL1: shared stdout markers; package/builder metadata (license, homepage, repository,
  copyright, tsbuildinfo glob)

Copy / docs / tests:
- M37 / SR9 dev-jargon cleanup in hints; M8 / M25 / M26 / L66 / L80 / L81 reconciled
- New unit tests for L35 (isValidMediaItem) and L36 (compareVersions)

This commit also checkpoints the previously-uncommitted feat/tray-background-clipboard
work it builds on: background running + auto-download, library clipboard detection,
tray, binary management & library scale, credential encryption at rest, the shared
jsonStore and ui/ primitives, and the eslint/prettier tooling.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-30 13:02:54 -04:00

76 lines
2.8 KiB
TypeScript

/**
* Windows Task Scheduler integration for the daily watched-source sync
* (ROADMAP-PINCHFLAT.md Phase J). Registers a task that launches AeroFetch with
* `--sync` once a day; the app then runs its startup sync of watched sources.
*
* NOTE: this is OS-level wiring and cannot be exercised in the Vite UI preview or
* the unit tests — like the `aerofetch://` protocol registration, it needs a real
* install + manual smoke test. `schtasks` is invoked via execFile (no shell), and
* the only interpolated value is the trusted `process.execPath`.
*/
import { execFile } from 'child_process'
import { getSystem32Path } from './binaries'
import type { ScheduledSyncStatus } from '@shared/ipc'
const TASK_NAME = 'AeroFetchDailySync'
/** The argv flag the scheduled task passes so startup knows it's a sync launch. */
export const SYNC_FLAG = '--sync'
function schtasks(args: string[]): Promise<{ code: number; stdout: string; stderr: string }> {
return new Promise((resolve) => {
// Resolve schtasks from System32 by absolute path, not the bare name, so a
// planted schtasks.exe on PATH / in the CWD can't be invoked instead. (audit F3)
execFile(
getSystem32Path('schtasks.exe'),
args,
{ windowsHide: true },
(err, stdout, stderr) => {
const code = err ? ((err as { code?: number }).code ?? 1) : 0
resolve({ code, stdout: String(stdout), stderr: String(stderr) })
}
)
})
}
/** True when this launch came from the scheduled task (argv carries --sync). */
export function isSyncLaunch(argv: string[]): boolean {
return argv.includes(SYNC_FLAG)
}
/** Whether the daily-sync scheduled task is currently registered. */
export async function getScheduledSync(): Promise<ScheduledSyncStatus> {
const r = await schtasks(['/Query', '/TN', TASK_NAME])
return { enabled: r.code === 0 }
}
/**
* Register or remove the daily-sync scheduled task. Creating runs AeroFetch with
* `--sync` every day at 09:00 (overwriting any prior task of the same name).
*/
export async function setScheduledSync(enabled: boolean): Promise<ScheduledSyncStatus> {
if (enabled) {
const tr = `"${process.execPath}" ${SYNC_FLAG}`
const r = await schtasks([
'/Create',
'/F',
'/SC',
'DAILY',
'/ST',
'09:00',
'/TN',
TASK_NAME,
'/TR',
tr
])
return {
enabled: r.code === 0,
error: r.code === 0 ? undefined : r.stderr.trim() || 'Could not create the scheduled task.'
}
}
const r = await schtasks(['/Delete', '/F', '/TN', TASK_NAME])
// A missing task ("cannot find") is success for our purposes — it's already gone.
const gone = r.code === 0 || /cannot find|does not exist/i.test(r.stderr)
return { enabled: gone ? false : true, error: gone ? undefined : r.stderr.trim() }
}