From 63a327a31c92384103a2486920e3d46b60285f18 Mon Sep 17 00:00:00 2001
From: debont80 <dmbont23@mailbox.org>
Date: Tue, 30 Jun 2026 14:01:25 -0400
Subject: [PATCH] Fix L7/M13/M37: badge colors, secret masking, dev-jargon
 hints

L7: Canceled status chip now uses 'subtle' color (neutral) instead of 'warning'
    (amber) -- distinguishing it from paused which remains amber.
M13: Proxy URL and YouTube PO-token inputs now use type="password" to mask
     credentials, matching updateToken. Proxy URLs can carry user:pass; PO tokens
     are opaque secrets.
M37: Rewrite two dev-facing hints -- youtubePlayerClient now says 'how AeroFetch
     identifies itself to YouTube' instead of citing yt-dlp internals; filename
     template says 'Controls how saved files are named' instead of 'yt-dlp output
     template'. Remaining hints (cookie browser, aria2c, etc.) were already clean.

typecheck + 242 tests + eslint + prettier green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 CODE-AUDIT.md                                 | 6 +++---
 src/renderer/src/components/SettingsView.tsx  | 6 ++++--
 src/renderer/src/components/ui/StatusChip.tsx | 2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/CODE-AUDIT.md b/CODE-AUDIT.md
index 51bd387..35588d9 100644
--- a/CODE-AUDIT.md
+++ b/CODE-AUDIT.md
@@ -258,7 +258,7 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
   `style={{ color: … }}` error spans + its local `errorRowText` class. The remaining red references live in
   per-component `makeStyles` classes (DownloadBar/LibraryView/QueueItem/TerminalView), not inline; migrate
   those to the shared hook incrementally.*
-- [ ] **M13 — Inconsistent secret-field masking.** `updateToken` uses `type="password"`; `proxy`
+- [x] **M13 — Inconsistent secret-field masking.** `updateToken` uses `type="password"`; `proxy`
   (may carry `user:pass@`) and `youtubePoToken` (a token) are plain-text Inputs.
 - [ ] **M14 — Settings search mutates React-owned DOM.** The search toggles each card's
   `el.style.display` directly; fragile (breaks if a card ever gets a conditional `style`) and
@@ -361,7 +361,7 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
   pending/error/canceled only, so selecting 5 rows (incl. 2 already-downloaded) shows "Download **3**
   selected." The checkbox count and the button count silently disagree. **Fix:** only show checkboxes on
   actionable rows, or count all selected.
-- [ ] **M37 — End-user hints leak developer/internal references.** Settings hints surface dev-facing
+- [x] **M37 — End-user hints leak developer/internal references.** Settings hints surface dev-facing
   detail: "Requires aria2c.exe in resources/bin (see the README there)", "paste a read-only **Gitea**
   token", "sent via `--extractor-args`", "breaking downloads with **403** errors", "open a locked cookie
   database", and roadmap status ("automatic minting is **planned**"). These read as code comments, not
@@ -388,7 +388,7 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
   where a class exists elsewhere.
 - [ ] **L6 — Control height mismatch.** `Select` is a fixed 32px sitting beside `size="large"`
   (~40px) Input/Buttons in DownloadBar.
-- [ ] **L7 — `canceled` and `paused` share the 'warning' badge color** (QueueItem) — visually
+- [x] **L7 — `canceled` and `paused` share the 'warning' badge color** (QueueItem) — visually
   ambiguous.
 - [ ] **L8 — Index/compound list keys.** TerminalView keys log lines by array index; Settings
   Diagnostics keys by `id + occurredAt` while every other list keys by `id` alone.
diff --git a/src/renderer/src/components/SettingsView.tsx b/src/renderer/src/components/SettingsView.tsx
index fbe6704..072b8f5 100644
--- a/src/renderer/src/components/SettingsView.tsx
+++ b/src/renderer/src/components/SettingsView.tsx
@@ -677,6 +677,7 @@ export function SettingsView(): React.JSX.Element {
           hint="HTTP/HTTPS/SOCKS proxy URL, e.g. socks5://127.0.0.1:1080. Leave blank to use the system default."
         >
           <Input
+            type="password"
             value={proxy}
             placeholder="socks5://127.0.0.1:1080"
             onChange={(_, d) => update({ proxy: d.value })}
@@ -707,7 +708,7 @@ export function SettingsView(): React.JSX.Element {
 
         <Field
           label="YouTube client (advanced)"
-          hint="Override the YouTube extraction client when downloads start failing the bot check. Try web_safari, tv, or mweb. Leave blank for yt-dlp's default."
+          hint="Override how AeroFetch identifies itself to YouTube when downloads start failing. Try web_safari, tv, or mweb. Leave blank for the automatic default."
         >
           <Input
             value={youtubePlayerClient}
@@ -725,6 +726,7 @@ export function SettingsView(): React.JSX.Element {
         >
           <div className={styles.folderRow}>
             <Input
+              type="password"
               style={{ flexGrow: 1 }}
               value={youtubePoToken}
               placeholder="(none)"
@@ -878,7 +880,7 @@ export function SettingsView(): React.JSX.Element {
         </div>
         <Field
           label="Filename template"
-          hint="yt-dlp output template. Tokens like %(title)s and %(ext)s are filled in per video."
+          hint="Controls how saved files are named. Use %(title)s for the video title, %(ext)s for the extension, and similar tokens."
         >
           <Input
             value={filenameTemplate}
diff --git a/src/renderer/src/components/ui/StatusChip.tsx b/src/renderer/src/components/ui/StatusChip.tsx
index 0132c17..0171f0c 100644
--- a/src/renderer/src/components/ui/StatusChip.tsx
+++ b/src/renderer/src/components/ui/StatusChip.tsx
@@ -21,7 +21,7 @@ const STATUS_CHIP: Record<ChipStatus, { label: string; color: ChipColor }> = {
   saved: { label: 'Saved', color: 'subtle' },
   completed: { label: 'Completed', color: 'success' },
   error: { label: 'Failed', color: 'danger' },
-  canceled: { label: 'Canceled', color: 'warning' }
+  canceled: { label: 'Canceled', color: 'subtle' }
 }
 
 /** Shared status chip used by the download queue and the library item list. */