Fix L46/L71/L74: unify yt-dlp missing message, editable dir inputs, swatch a11y

L46: Introduced YTDLP_MISSING_MSG constant in binaries.ts. All four callers
     (download, indexer, probe, ytdlp) now emit the same user-facing string:
     "yt-dlp.exe is missing. Open Settings -> Software update to re-download it."
     This removes newline-embedded messages and four divergent phrasings.

L71: Removed readOnly from videoDir/audioDir folder inputs in SettingsView.
     Added onChange handler so users can paste or type a path directly without
     being forced to use the Browse button. The path still flows through
     applySettings() in main, which validates it.

L74: Accent color swatches were triple-labeled (aria-pressed + aria-label +
     title). Replaced with a single aria-label that embeds "(selected)" state,
     plus title for the hover tooltip. Removed the incorrect aria-pressed
     (these are selection buttons, not toggles).

typecheck + 242 tests green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-06-30 14:27:02 -04:00
parent b035a88873
commit 3ae4a5357c
7 changed files with 20 additions and 16 deletions
+3 -3
View File
@@ -469,7 +469,7 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
but there's no ESLint/Prettier config, script, or dependency — no enforced style tooling.
- [x] **L45 — Three self-descriptions** drift: pkg `description` "A yt-dlp frontend for Windows" vs
builder `copyright` "yt-dlp frontend" vs Sidebar caption "yt-dlp frontend".
- [ ] **L46 — yt-dlp-missing error copy differs across 4 modules** (download/ytdlp/probe/indexer):
- [x] **L46 — yt-dlp-missing error copy differs across 4 modules** (download/ytdlp/probe/indexer):
"Reinstall AeroFetch, or drop…" vs "Download it into resources/bin/…" vs "Drop it into resources/bin/."
- [x] **L47 — `probeMeta` 30s timeout returns null silently** — no surfaced message, unlike every
other yt-dlp timeout ("Timed out …").
@@ -510,12 +510,12 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
(`typeof crypto !== 'undefined'` is always true) — dead defensive branch (see M7). *Fixed with M7: the
branch now lives once in `newId` (kept so the fn is total in any host) and is covered by a test that stubs
`crypto` to exercise it.*
- [ ] **L71 — Settings folder inputs are `readOnly`** with only a Browse button — no way to paste a
- [x] **L71 — Settings folder inputs are `readOnly`** with only a Browse button — no way to paste a
known path.
- [x] **L72 — History re-download drops the thumbnail** (passes only title/channel), so the
re-queued row loses its thumbnail until re-probed.
- [ ] **L73 — Two verbs for the same probe action** — DownloadBar "Fetch" vs LibraryView "Index".
- [ ] **L74 — Accent swatches are triple-labeled** (`aria-pressed` + `aria-label` + `title`).
- [x] **L74 — Accent swatches are triple-labeled** (`aria-pressed` + `aria-label` + `title`).
- [x] **L75 — Update-token field always visible** in the Software-update card, even when no update
is pending — buries an advanced/rarely-needed input.
- [x] **L76 — Duplicate-warning may show a placeholder title**`setDup(existing.title)` can be the
+4
View File
@@ -80,6 +80,10 @@ export function getFfprobePath(): string {
return join(getBinDir(), 'ffprobe.exe')
}
/** User-facing error shown whenever yt-dlp.exe is not found at startup. */
export const YTDLP_MISSING_MSG =
'yt-dlp.exe is missing. Open Settings → Software update to re-download it.'
/** Optional bundled external downloader; absent unless dropped into resources/bin. */
export function getAria2cPath(): string {
return join(getBinDir(), 'aria2c.exe')
+3 -2
View File
@@ -10,7 +10,8 @@ import {
getFfmpegPath,
getFfprobePath,
getSystem32Path,
getAppIconImage
getAppIconImage,
YTDLP_MISSING_MSG
} from './binaries'
import { getSettings, getDownloadArchivePath, getDefaultMediaDir } from './settings'
import { ensureManagedYtdlp } from './ytdlp'
@@ -225,7 +226,7 @@ export function startDownload(wc: WebContents, opts: StartDownloadOptions): Star
if (!existsSync(ytdlp)) {
return {
ok: false,
error: `yt-dlp.exe is missing and couldn't be restored from the bundle.\nReinstall AeroFetch, or drop yt-dlp.exe into resources/bin/ (see the README there).`
error: YTDLP_MISSING_MSG
}
}
// ffmpeg is used by nearly every download (merge, audio extract, thumbnail/
+2 -2
View File
@@ -11,7 +11,7 @@
import { execFile } from 'child_process'
import { existsSync } from 'fs'
import { getYtdlpPath } from './binaries'
import { getYtdlpPath, YTDLP_MISSING_MSG } from './binaries'
import { cleanError } from './log'
import { assertHttpUrl } from './url'
import {
@@ -90,7 +90,7 @@ export async function indexSource(
return { ok: false, error: (e as Error).message }
}
if (!existsSync(getYtdlpPath())) {
return { ok: false, error: 'yt-dlp.exe not found. Drop it into resources/bin/.' }
return { ok: false, error: YTDLP_MISSING_MSG }
}
const cls = classifySource(url)
+2 -2
View File
@@ -1,6 +1,6 @@
import { execFile } from 'child_process'
import { existsSync } from 'fs'
import { getYtdlpPath } from './binaries'
import { getYtdlpPath, YTDLP_MISSING_MSG } from './binaries'
import { fmtBytes } from './lib/formatters'
import { cleanError } from './log'
import { assertHttpUrl } from './url'
@@ -115,7 +115,7 @@ export function probeMedia(url: string): Promise<ProbeResult> {
if (!existsSync(ytdlp)) {
return Promise.resolve({
ok: false,
error: `yt-dlp.exe not found at ${ytdlp}\nDrop it into resources/bin/ (see the README there).`
error: YTDLP_MISSING_MSG
})
}
let target: string
+3 -3
View File
@@ -1,7 +1,7 @@
import { execFile } from 'child_process'
import { existsSync, mkdirSync, copyFileSync } from 'fs'
import { dirname } from 'path'
import { getYtdlpPath, getBundledYtdlpPath } from './binaries'
import { getYtdlpPath, getBundledYtdlpPath, YTDLP_MISSING_MSG } from './binaries'
import { getSettings, setSettings } from './settings'
import { shouldAutoCheckYtdlp } from './ytdlpPolicy'
import {
@@ -39,7 +39,7 @@ export function getYtdlpVersion(): Promise<YtdlpVersionResult> {
if (!existsSync(ytdlpPath)) {
return Promise.resolve({
ok: false,
error: `yt-dlp.exe not found at ${ytdlpPath}\nDownload it into resources/bin/ (see the README there).`
error: YTDLP_MISSING_MSG
})
}
@@ -85,7 +85,7 @@ export function updateYtdlp(channel: YtdlpUpdateChannel): Promise<YtdlpUpdateRes
if (!existsSync(ytdlpPath)) {
return Promise.resolve({
ok: false,
error: `yt-dlp.exe not found at ${ytdlpPath}\nDownload it into resources/bin/ (see the README there).`
error: YTDLP_MISSING_MSG
})
}
+3 -4
View File
@@ -485,11 +485,11 @@ export function SettingsView(): React.JSX.Element {
>
<div className={styles.folderRow}>
<Input
readOnly
className={styles.folderInput}
value={videoDir}
placeholder="Documents\Video (default)"
contentBefore={<FolderRegular />}
onChange={(_, d) => update({ videoDir: d.value })}
/>
<Button icon={<FolderRegular />} onClick={() => chooseDir('videoDir')}>
Browse
@@ -508,11 +508,11 @@ export function SettingsView(): React.JSX.Element {
>
<div className={styles.folderRow}>
<Input
readOnly
className={styles.folderInput}
value={audioDir}
placeholder="Documents\Audio (default)"
contentBefore={<FolderRegular />}
onChange={(_, d) => update({ audioDir: d.value })}
/>
<Button icon={<FolderRegular />} onClick={() => chooseDir('audioDir')}>
Browse
@@ -625,8 +625,7 @@ export function SettingsView(): React.JSX.Element {
)}
style={{ backgroundColor: opt.swatch }}
onClick={() => update({ accentColor: opt.value as AccentColor })}
aria-pressed={accentColor === opt.value}
aria-label={opt.label}
aria-label={`${opt.label}${accentColor === opt.value ? ' (selected)' : ''}`}
title={opt.label}
/>
))}