debont80/AeroFetch
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 9 Wiki Activity

Fix L106/L107/L122: unify refresh icons, spinner size, busy-button feedback

Browse Source 
L106: Established the convention — ArrowClockwise = retry/redo a local action
      (retry-all, re-download, retry queue item); ArrowSync = network sync/
      update (sync sources, reindex, check/apply updates). Flipped the two
      misclassified sites (LibraryView "check for new" sync, SettingsView
      "Update yt-dlp") to ArrowSync and dropped the now-unused imports.

L107: QueueItem queued-row Spinner was size="extra-tiny"; every other spinner
      is "tiny". Standardized to "tiny".

L122: The app-update and yt-dlp-update buttons showed "Checking…"/"Updating…"
      in the label AND a separate sibling Spinner. Folded the spinner into the
      button icon (icon swaps to Spinner while busy), matching DownloadBar/
      LibraryView, and removed the redundant sibling Spinner.

typecheck + 242 tests + eslint green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Devon Bontrager
2026-06-30 15:29:19 -04:00
parent d7b5737806
commit 0d2000f307
4 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CODE-AUDIT.md
+3 -3
View File
@@ -587,9 +587,9 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
[store/downloads.ts](src/renderer/src/store/downloads.ts); components import it from both. Single source it.
*Fixed: the store now imports `MediaKind` from `@shared/ipc` and re-exports it, so the duplicate local
`type MediaKind` is gone while existing `import { MediaKind } from '../store/downloads'` sites still resolve.*
- [ ] **L106 — Refresh icons used interchangeably.** `ArrowClockwiseRegular` (retry, re-download,
- [x] **L106 — Refresh icons used interchangeably.** `ArrowClockwiseRegular` (retry, re-download,
check-for-new, update-yt-dlp) vs `ArrowSyncRegular` (re-index, check-for-updates) for the same "redo/refresh" idea.
- [ ] **L107 — Spinner sizes mixed** — `"tiny"` almost everywhere, `"extra-tiny"` for the QueueItem queued row.
- [x] **L107 — Spinner sizes mixed** — `"tiny"` almost everywhere, `"extra-tiny"` for the QueueItem queued row.
- [x] **L108 — Main window sets no explicit `title`** (relies on the document `<title>`).
- [ ] **L109 — Versions auto-load with no indicator.** yt-dlp/ffmpeg versions in About just appear;
only the manual "Check" button shows a spinner.
@@ -612,7 +612,7 @@ token system + shared primitives (UI/SIMP — high value, larger effort) · i18n
other card surface is a bespoke styled `<div>`.
- [ ] **L121 — Raw scrim literal.** CommandPalette backdrop is `rgba(0,0,0,0.32)` (the only raw rgba in
the renderer), identical in light/dark — low contrast over a dark UI.
- [ ] **L122 — "Checking…" indicated twice** — the Settings update button changes its label to "Checking…" *and* a separate Spinner renders beside it.
- [x] **L122 — "Checking…" indicated twice** — the Settings update button changes its label to "Checking…" *and* a separate Spinner renders beside it.
- [ ] **L123 — `Caption1` is overloaded** for hints, metadata, counts, and timestamps — one size doing four jobs.
- [ ] **L124 — `Body1` vs `Text` role overlap** — `Body1` appears only in empty states/onboarding/gate; `Text` carries titles; the split isn't principled.
- [ ] **L125 — Icon sizing has two syntaxes** — px strings (`fontSize: '20px'`) on icon *containers* vs numeric `fontSize={28}` on inline icons.