feat(m4): persist the download queue across restarts
The queue/scheduler lived only in renderer memory, so saved/scheduled and other pending downloads were silently lost on quit (audit M4). Persist them: - main: queue.ts store (proven cached-atomic createJsonStore, queue.json) + queue:list / queue:save IPC; QUEUE_MAX cap. - shared: PersistedQueueItem = the durable subset of DownloadItem (runtime-only progress/speed/eta/sizeLabel/finishing dropped). - renderer: mirror the persistable items on every queue change (a signature over the subset means progress ticks don't re-save; main's jsonStore coalesces the writes) and rehydrate on launch via an App useEffect. Pure mappers extracted to store/queuePersist.ts and unit-tested. Restore semantics: downloading -> queued (yt-dlp continues the .part), saved + scheduledFor survives so the promoter fires when due, paused/error return actionable; completed/canceled are never persisted. A queueHydrated gate stops a launch-time store change from wiping queue.json before it's read. Reconciles ROADMAP.md. typecheck + 268 tests + eslint + prettier green. (OS-level quit/relaunch cycle is worth a manual smoke test.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -63,3 +63,5 @@ export const ERRORLOG_MAX_ENTRIES = 200
|
||||
export const TEMPLATES_MAX = 100
|
||||
/** Indexed media items across all sources (media-items.json). */
|
||||
export const MEDIA_ITEMS_MAX = 20_000
|
||||
/** Persisted download-queue rows (queue.json, M4) — generous; a whole channel can be queued. */
|
||||
export const QUEUE_MAX = 10_000
|
||||
|
||||
+8
-1
@@ -21,7 +21,8 @@ import {
|
||||
type CommandTemplate,
|
||||
type YtdlpUpdateChannel,
|
||||
type SystemThemeInfo,
|
||||
type TaskbarProgress
|
||||
type TaskbarProgress,
|
||||
type PersistedQueueItem
|
||||
} from '@shared/ipc'
|
||||
import { PAGE_BACKGROUND } from '@shared/theme'
|
||||
import { getYtdlpVersion, updateYtdlp } from './ytdlp'
|
||||
@@ -36,6 +37,7 @@ import { listTemplates, saveTemplate, removeTemplate } from './templates'
|
||||
import { safeOpenPath, safeShowInFolder } from './reveal'
|
||||
import { openCookieLoginWindow, getCookiesStatus, clearCookies } from './cookies'
|
||||
import { listErrorLog, addErrorLog, clearErrorLog } from './errorlog'
|
||||
import { listQueue, saveQueue } from './queue'
|
||||
import { exportBackup, importBackup } from './backup'
|
||||
import {
|
||||
listSources,
|
||||
@@ -208,6 +210,11 @@ export function registerIpcHandlers(getMainWindow: () => BrowserWindow | null):
|
||||
ipcMain.handle(IpcChannels.errorLogList, () => listErrorLog())
|
||||
ipcMain.handle(IpcChannels.errorLogClear, () => clearErrorLog())
|
||||
|
||||
// Persisted download queue (M4): the renderer mirrors its durable items here and
|
||||
// rehydrates them on launch, so saved/scheduled/pending downloads survive a quit.
|
||||
ipcMain.handle(IpcChannels.queueList, () => listQueue())
|
||||
ipcMain.handle(IpcChannels.queueSave, (_e, items: PersistedQueueItem[]) => saveQueue(items))
|
||||
|
||||
ipcMain.handle(IpcChannels.backupExport, (e) =>
|
||||
exportBackup(BrowserWindow.fromWebContents(e.sender) ?? undefined)
|
||||
)
|
||||
|
||||
@@ -0,0 +1,46 @@
|
||||
import { createJsonStore } from './jsonStore'
|
||||
import { QUEUE_MAX } from './constants'
|
||||
import type { PersistedQueueItem, PersistedQueueStatus } from '@shared/ipc'
|
||||
|
||||
/**
|
||||
* Persistence for the download queue (M4). The queue lived only in renderer memory,
|
||||
* so `saved` / scheduled and other pending downloads were silently lost on quit.
|
||||
* The renderer now mirrors its durable items here (via `queueSave`) and rehydrates
|
||||
* them on launch (via `queueList`), so a parked/scheduled download returns.
|
||||
*
|
||||
* Reuses the shared cached-atomic `createJsonStore` (R1/R2/R3), so writes are atomic
|
||||
* and coalesced — the renderer can call `queueSave` freely on queue changes.
|
||||
*/
|
||||
|
||||
const PERSISTED_STATUSES: readonly PersistedQueueStatus[] = [
|
||||
'queued',
|
||||
'downloading',
|
||||
'paused',
|
||||
'saved',
|
||||
'error'
|
||||
]
|
||||
|
||||
/** Defensive row validator (a hand-edited or partially-written file can't crash a read). */
|
||||
function isValidQueueItem(o: unknown): o is PersistedQueueItem {
|
||||
if (typeof o !== 'object' || o === null) return false
|
||||
const it = o as Record<string, unknown>
|
||||
return (
|
||||
typeof it.id === 'string' &&
|
||||
typeof it.url === 'string' &&
|
||||
typeof it.title === 'string' &&
|
||||
(it.kind === 'video' || it.kind === 'audio') &&
|
||||
typeof it.quality === 'string' &&
|
||||
typeof it.status === 'string' &&
|
||||
(PERSISTED_STATUSES as readonly string[]).includes(it.status)
|
||||
)
|
||||
}
|
||||
|
||||
const store = createJsonStore('queue.json', isValidQueueItem, QUEUE_MAX)
|
||||
|
||||
export function listQueue(): PersistedQueueItem[] {
|
||||
return store.read()
|
||||
}
|
||||
|
||||
export function saveQueue(items: PersistedQueueItem[]): void {
|
||||
store.write(items)
|
||||
}
|
||||
Reference in New Issue
Block a user